Fix homepage in theme.json for Sine installations#60
Fix homepage in theme.json for Sine installations#60yungando wants to merge 2 commits intoKiKaraage:mainfrom
Conversation
Summary of ChangesHello @yungando, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue preventing the Sine Theme Manager from performing automatic updates for the 'Zen Context Menu' theme. The Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the homepage URL in theme.json to address the auto-update issue with Sine Theme Manager. The change is appropriate for the described goal. I have left one minor suggestion regarding file formatting.
I am having trouble creating individual review comments. Click here to see my feedback.
Zen-context-menu/theme.json (17)
The trailing newline at the end of the file has been removed. It is a strong convention in software development to end files with a newline character. This ensures compatibility with various command-line tools and prevents issues with file concatenation or processing. Please add the newline back.
Sine Theme Manager currently uses the
homepagefromtheme.jsonto decide where to pull mod updates from.Homepagecurrently points to the root folder of this repo, which doesn't hold the mod files - this causes auto-updates via Sine to fail.This PR changes the
homepageto the Zen Theme Store repo folder that does store the mod files. The creator of Sine has said they're working on separating out anoriginproperty that would dictate where to pull updates from, as opposed to using the mod author's desiredhomepage- in the mean time this should fix the issue for Sine users.Also this repo's version of the mod seems to be behind the Zen Theme Store version (
2.0compared to3.1). If merged, this change will also need to be applied to the Zen Theme Store.Cheers!