Skip to content

refactor: centralize the retrograde symbol definition into a new constant #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2mx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: centralize the retrograde symbol definition into a new constant #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf5ee4
refactor: centralize the retrograde symbol definition into a new cons…
2mx Feb 24, 2026
baa5ac1
refactor: rename `POINT_RETROGRADE_SYMBOL` to `POINT_RETROGRADE_SYMBO…
2mx Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/settings/constants/Point.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,12 @@ export const POINT_PROPERTIES_FONT_SIZE = 16
* @default 2
*/
export const POINT_COLLISION_RADIUS = 12

/**
* Retrograde symbol
* @constant
* @type {String}
* @property choices M for Px symbol or N for R symbol
* @default "M"
*/
export const POINT_RETROGRADE_SYMBOL_CODE = "M"
6 changes: 4 additions & 2 deletions src/utils/SVGUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { POINT_RETROGRADE_SYMBOL_CODE } from '../settings/constants/Point.js';

/**
* @class
* @classdesc SVG utility class
Expand Down Expand Up @@ -90,7 +92,7 @@ class SVGUtils {
static SYMBOL_MC_CODE = "d";
static SYMBOL_IC_CODE = "e";

static SYMBOL_RETROGRADE_CODE = "M"
static SYMBOL_RETROGRADE_CODE = POINT_RETROGRADE_SYMBOL_CODE;

static SYMBOL_CONJUNCTION_CODE = "!";
static SYMBOL_OPPOSITION_CODE = '"';
Expand Down Expand Up @@ -679,5 +681,5 @@ class SVGUtils {

export {
SVGUtils as
default
default
}