also show in the autocomplete settings when no provider is available #2904

markijbema · 2025-10-10T11:31:18Z

we currently only support codestral, and have only configured this for 3 providers. It currently fails silently if these arent available, make more clear what is happening

Fixes: #2907

changeset-bot · 2025-10-10T11:31:22Z

⚠️ No Changeset found

Latest commit: c5711a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

markijbema · 2025-10-16T11:47:32Z

webview-ui/src/components/kilocode/settings/GhostServiceSettings.tsx

+								</>
+							) : (
+								<div className="text-vscode-errorForeground">
+									No suitable autocomplete model found. Please configure a provider in the API


todo translate

webview-ui/src/components/settings/ApiOptions.tsx

webview-ui/src/components/settings/__tests__/ApiOptions.spec.tsx

webview-ui/src/components/settings/__tests__/SettingsView.spec.tsx

markijbema · 2025-10-16T14:24:00Z

src/services/ghost/__tests__/GhostModel.spec.ts

@@ -0,0 +1,325 @@
+import { describe, it, expect, vi, beforeEach } from "vitest"


This is all vibed. I have the impression this helps guide the LLM a lot, if anyone feels it would be better to remove thats fine by me as well

removed duplicate null checks by using types. also added test

add proper cleanup instead of sticking to the old profile if we cant find one

Copilot

Pull Request Overview

Adds provider/model visibility and clearer error messaging when no autocomplete provider/model is configured, plus logic to select a usable provider and expose it in the status bar and settings UI.

Introduces provider/model fields to Ghost service settings and displays them in UI with error fallback.
Refactors GhostModel reload logic to iterate supported providers and adds balance check for kilocode; updates status bar tooltip and global context.
Adds tests for GhostModel provider usability scenarios and new i18n keys across locales.

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
webview-ui/src/i18n/locales/*/kilocode.json	Adds new translation keys for provider/model and noModelConfigured message.
webview-ui/src/components/kilocode/settings/GhostServiceSettings.tsx	Displays provider/model or error message when missing.
webview-ui/src/components/kilocode/settings/tests/GhostServiceSettings.spec.tsx	Tests UI rendering of provider/model and error message cases.
src/services/ghost/GhostModel.ts	Refactors provider selection logic, adds provider display name accessor.
src/services/ghost/tests/GhostModel.spec.ts	Adds tests for provider usability (balance, token presence) and provider display name.
src/services/ghost/GhostProvider.ts	Integrates new model/provider info into context and status bar.
src/services/ghost/GhostStatusBar.ts	Adds provider to status bar tooltip and state.
src/i18n/locales/*/kilocode.json	Adds provider key for status bar tooltip in all locales.
src/core/webview/webviewMessageHandler.ts	Triggers ghost reload after API provider settings change.
src/core/webview/tests/webviewMessageHandler.autoSwitch.spec.ts	Mocks vscode.commands to support reload invocation.
packages/types/src/provider-settings.ts	Defines autocomplete provider models and usability checker.
packages/types/src/kilocode/kilocode.ts	Extends schema with provider/model and adds balance check helper.

Copilot · 2025-10-17T08:48:40Z

src/services/ghost/GhostModel.ts

+				const isUsable = await defaultProviderUsabilityChecker(provider, providerSettingsManager)
+				if (!isUsable) continue
+
+				this.loadProfile(providerSettingsManager, selectedProfile, provider)


loadProfile is async and not awaited; this.loaded may be set and true returned before profile/model info is actually loaded or fetchModel completes. Add await before this.loadProfile to avoid race conditions.

Suggested change

this.loadProfile(providerSettingsManager, selectedProfile, provider)

await this.loadProfile(providerSettingsManager, selectedProfile, provider)

Copilot · 2025-10-17T08:48:41Z

src/services/ghost/__tests__/GhostModel.spec.ts

+				if (url.includes("/api/profile/balance")) {
+					return {
+						ok: true,
+						json: async () => ({ data: { balance: 0 } }),


checkKilocodeBalance expects a top-level balance property (data.balance ?? 0); this mock returns nested { data: { balance: 0 } } causing balance to be treated as 0 even if intended otherwise. Return { balance: 0 } instead to align with the production function.

Suggested change

json: async () => ({ data: { balance: 0 } }),

json: async () => ({ balance: 0 }),

Copilot · 2025-10-17T08:48:41Z

src/services/ghost/__tests__/GhostModel.spec.ts

+				if (url.includes("/api/profile/balance")) {
+					return {
+						ok: true,
+						json: async () => ({ data: { balance: 10.5 } }),


Positive balance mock also uses nested { data: { balance: 10.5 } } so checkKilocodeBalance interprets balance as 0; change to { balance: 10.5 } to exercise the intended path of selecting kilocode.

Suggested change

json: async () => ({ data: { balance: 10.5 } }),

json: async () => ({ balance: 10.5 }),

Copilot · 2025-10-17T08:48:41Z

src/services/ghost/GhostProvider.ts

+		await this.model.reload(this.providerSettingsManager)
 		this.cursorAnimation.updateSettings(this.settings || undefined)
 		await this.updateGlobalContext()
 		this.updateStatusBar()


[nitpick] Because GhostModel.reload does not await loadProfile (see earlier issue), updateGlobalContext and updateStatusBar may run before provider/model data is ready. After fixing reload, consider moving updateStatusBar into updateGlobalContext or adding explicit sequencing comments for clarity.

Suggested change

this.updateStatusBar()

Copilot · 2025-10-17T08:48:41Z

packages/types/src/provider-settings.ts

+export const defaultProviderUsabilityChecker: ProviderUsabilityChecker = async (provider, providerSettingsManager) => {
+	if (provider === "kilocode") {
+		try {
+			const profiles = await providerSettingsManager.listConfig()
+			const kilocodeProfile = profiles.find((p) => p.apiProvider === "kilocode")
+
+			if (!kilocodeProfile) {
+				return false
+			}
+
+			const profile = await providerSettingsManager.getProfile({ id: kilocodeProfile.id })
+			const kilocodeToken = profile.kilocodeToken
+
+			if (!kilocodeToken) {
+				return false
+			}
+
+			return await checkKilocodeBalance(kilocodeToken)
+		} catch (error) {
+			console.error("Error checking kilocode balance:", error)
+			return false
+		}
+	}
+
+	// For all other providers, assume they are usable
+	return true
+}


listConfig is called here after already being invoked in GhostModel.reload; pass the profiles array into defaultProviderUsabilityChecker to avoid duplicate I/O, reducing latency when many providers are added.

Copilot · 2025-10-17T08:48:42Z

packages/types/src/provider-settings.ts

+export const AUTOCOMPLETE_PROVIDER_MODELS = {
+	mistral: "codestral-latest",
+	kilocode: "mistralai/codestral-2508",
+	openrouter: "mistralai/codestral-2508",
+} as const satisfies Record<Extract<ProviderName, "mistral" | "kilocode" | "openrouter">, string>
+
+export type AutocompleteProviderKey = keyof typeof AUTOCOMPLETE_PROVIDER_MODELS
+
+interface ProviderSettingsManager {
+	listConfig(): Promise<ProviderSettingsEntry[]>
+	getProfile(params: { id: string }): Promise<ProviderSettings>
+}
+
+export type ProviderUsabilityChecker = (
+	provider: AutocompleteProviderKey,
+	providerSettingsManager: ProviderSettingsManager,
+) => Promise<boolean>
+
+export const defaultProviderUsabilityChecker: ProviderUsabilityChecker = async (provider, providerSettingsManager) => {


Newly added block should be marked with project-specific change annotations (kilocode_change) to ease upstream merges; wrap these consecutive lines with start/end markers.

Copilot · 2025-10-17T08:48:42Z

packages/types/src/kilocode/kilocode.ts

+		}
+
+		const data = await response.json()
+		const balance = data.balance ?? 0


[nitpick] API parsing assumes a top-level balance; tests currently mock nested { data: { balance } }. If the real endpoint returns nested balance, this logic will incorrectly treat it as zero. Confirm endpoint shape and, if nested, change to const balance = (data.balance ?? data.data?.balance ?? 0).

Suggested change

const balance = data.balance ?? 0

const balance = data.balance ?? data.data?.balance ?? 0

Copilot · 2025-10-17T08:48:42Z

src/services/ghost/GhostModel.ts

+		const handler = this.apiHandler as any
+		if (handler.providerName && typeof handler.providerName === "string") {
+			return handler.providerName


[nitpick] Casting apiHandler to any and relying on providerName risks silent 'unknown' results; derive provider from the selected profile or handler class instead (e.g., expose a typed getProviderName() on ApiHandler).

Suggested change

const handler = this.apiHandler as any

if (handler.providerName && typeof handler.providerName === "string") {

return handler.providerName

const providerName = this.apiHandler.getProviderName?.()

if (providerName && typeof providerName === "string") {

return providerName

markijbema · 2025-10-17T08:56:58Z

src/core/webview/webviewMessageHandler.ts

 					const listApiConfig = await provider.providerSettingsManager.listConfig()
 					await updateGlobalState("listApiConfigMeta", listApiConfig)
+					// Reload ghost model when API provider settings change
+					vscode.commands.executeCommand("kilo-code.ghost.reload")


kilocode chdange

markijbema · 2025-10-17T08:57:06Z

packages/types/src/provider-settings.ts

 import { z } from "zod"

 import { modelInfoSchema, reasoningEffortWithMinimalSchema, verbosityLevelsSchema, serviceTierSchema } from "./model.js"
+import { checkKilocodeBalance } from "./kilocode/kilocode.js"


kilocode chaneg

markijbema · 2025-10-17T08:57:26Z

packages/types/src/provider-settings.ts

 export const isProviderName = (key: unknown): key is ProviderName =>
 	typeof key === "string" && providerNames.includes(key as ProviderName)

+export const AUTOCOMPLETE_PROVIDER_MODELS = {


losse file?

beatlevic

LGTM

markijbema commented Oct 16, 2025

View reviewed changes

webview-ui/src/components/settings/ApiOptions.tsx Outdated Show resolved Hide resolved

markijbema commented Oct 16, 2025

View reviewed changes

webview-ui/src/components/settings/__tests__/ApiOptions.spec.tsx Outdated Show resolved Hide resolved

markijbema commented Oct 16, 2025

View reviewed changes

webview-ui/src/components/settings/__tests__/SettingsView.spec.tsx Outdated Show resolved Hide resolved

markijbema force-pushed the mark/supported-autocomplete-providers branch from e326302 to 5dcd224 Compare October 16, 2025 12:58

markijbema mentioned this pull request Oct 16, 2025

move method so it is easier to reuse #3072

Merged

markijbema force-pushed the mark/supported-autocomplete-providers branch from 5dcd224 to b6a9d20 Compare October 16, 2025 14:17

markijbema commented Oct 16, 2025

View reviewed changes

markijbema force-pushed the mark/supported-autocomplete-providers branch from 64b381c to 2f43209 Compare October 16, 2025 15:28

markijbema requested review from EamonNerbonne and beatlevic October 17, 2025 08:25

markijbema added 18 commits October 17, 2025 10:43

also show in the settings when no provider is available

b8daa75

deduplicate

e0000d3

remove unused import

b2e4811

remove unused param

1c6a416

move model options together

651d87a

typesafe

68526fe

simplify

6a76b40

fix

f1cfd02

add missing translations

20138b5

fix

25d5e86

simplify

7f5120c

make provider selection code simpler

3bbafa6

removed duplicate null checks by using types. also added test

remove hardcoding

97d97f6

switch over which list we are looping

32a2de0

simplify

5b0e9b2

show provider name in autocomplete tooltip

3194961

remove hardcoded list

d3e6337

do not say we have loaded when we havent

567869f

add proper cleanup instead of sticking to the old profile if we cant find one

markijbema added 13 commits October 17, 2025 10:43

reuse balanche checking

f78f4d4

remove translation

47f5b42

remove changes from settings screen

83aa99a

also merge files here

7e08560

fix import

d45e447

add mocks

e68ea25

remove redundant comments

6891691

remove

3c50e8f

update translations

17a2e12

more translations

21ab677

fix

9c83b5d

reload autocomplete after changing settings

c626bdc

fix bug in balance check

a41b712

markijbema force-pushed the mark/supported-autocomplete-providers branch from ed67182 to a41b712 Compare October 17, 2025 08:43

markijbema requested a review from Copilot October 17, 2025 08:45

Copilot AI reviewed Oct 17, 2025

View reviewed changes

less complex types

9e3e2d4

EamonNerbonne approved these changes Oct 17, 2025

View reviewed changes

markijbema commented Oct 17, 2025

View reviewed changes

markijbema added 4 commits October 17, 2025 11:14

refactor(types): relocate autocomplete provider config to kilocode

a47d6ca

add org support

4dd1cd1

mark kilocode change

8776697

fix

c5711a1

markijbema marked this pull request as ready for review October 17, 2025 09:29

markijbema enabled auto-merge October 17, 2025 09:29

beatlevic approved these changes Oct 17, 2025

View reviewed changes

markijbema merged commit c5248e8 into main Oct 17, 2025
19 checks passed

markijbema deleted the mark/supported-autocomplete-providers branch October 17, 2025 09:32

		@@ -0,0 +1,325 @@
		import { describe, it, expect, vi, beforeEach } from "vitest"

	this.loadProfile(providerSettingsManager, selectedProfile, provider)
	await this.loadProfile(providerSettingsManager, selectedProfile, provider)

	json: async () => ({ data: { balance: 0 } }),
	json: async () => ({ balance: 0 }),

	json: async () => ({ data: { balance: 10.5 } }),
	json: async () => ({ balance: 10.5 }),

	const balance = data.balance ?? 0
	const balance = data.balance ?? data.data?.balance ?? 0

also show in the autocomplete settings when no provider is available #2904

also show in the autocomplete settings when no provider is available #2904

Conversation

markijbema commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

markijbema Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

markijbema Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

markijbema Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

markijbema Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

markijbema Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

beatlevic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

markijbema commented Oct 10, 2025 •

edited

Loading

changeset-bot bot commented Oct 10, 2025 •

edited

Loading