phreeqc2026 engine: ensure unit osmotic coefficient; refactor tests #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the
phreeqc2026engine returns a unit osmotic coefficient, unless PHREEQC itself returns a value other than zero. This is necessary to ensure that osmotic pressure calculations work as intended.It also contains a bugfix where, if a user tries to use
get_osmotic_coefficientwithout having first runequilibrate, there would be an error because theppsolattribute has not been initialized.Finally, unit test files are renamed and a new unit test added for both
phreeqcandphreeqc2026engines.