Open
Conversation
wathigo
suggested changes
Oct 30, 2019
There was a problem hiding this comment.
Changes Required
All the changes requested by @maelfosso are yet to be implemented.
Check the Ruby docs for the expected behavior of the enumerable methods.
Please don't open a new Pull Request before it has been approved.
Let's also address this:
my_countmethod is not well indented and not all the blocks have not been closed with andendstatement`.
See this 👇
After implementing the changes, submit another request for review.
Happy Coding 💻
Reviewed by: Simon Wathigo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.