Skip to content
This repository was archived by the owner on Aug 14, 2025. It is now read-only.

Feature/add all transaction list query#246

Open
golnar-boosty wants to merge 9 commits intomasterfrom
feature/add_all_transaction_list_query
Open

Feature/add all transaction list query#246
golnar-boosty wants to merge 9 commits intomasterfrom
feature/add_all_transaction_list_query

Conversation

@golnar-boosty
Copy link
Collaborator

No description provided.

golnar-boosty and others added 9 commits November 19, 2024 18:11
…ded a function to simplify the creation of

tx_search endpoint URLs. This utility takes the RPC address, query, pagination parameters, and order criteria as input, and returns a
well-formatted endpoint string.
…struct.

- Added a  field to the  struct to include the block height in transaction details.
- Introduced a new  struct for wrapping multiple transactions with a total count, enhancing API response consistency.

This change improves the API structure by providing more granular transaction information and supporting batch responses effectively.
…Added as a direct dependency in .

- Removed its previous listing as an indirect dependency. This change ensures the  package is explicitly managed, improving dependency clarity and avoiding potential issues with transitive dependency resolution.
…ieval.Updated interx.tx_test.go to use types.TxsResponse instead of TxsResponse for consistency with the types package. Added getBlockHeight function to retrieve block height for a transaction hash from cache or Tendermint. Improved error handling and logging in getBlockHeight.
…ehavior. Refactored GetTransactions to simplify file path construction using basePath and suffix. Added a new resolveFileName helper function to centralize file name determination logic. Updated SaveTransactions to use resolveFileName, improving readability and maintainability. Improved conditional handling in SaveTransactions to append cached transactions only when an address is provided. Enhanced error logging with more descriptive messages in SaveTransactions.
…ng.Removed the redundant TxsResponse definition and replaced it with types.TxsResponse for consistency.Refactored GetTransactionsWithSync. Consolidated outbound and inbound logic with improved query construction.Eliminated unnecessary checks for empty addresses.Replaced repetitive endpoint construction with BuildTxSearchEndpoint.

Simplified GetFilteredTransactions.Introduced processDirection to handle direction-specific logic modularly.Removed redundant loops and conditions for processing inbound and outbound transactions.Added processDirection as a reusable function for transaction direction handling.Enhanced QueryBlockTransactionsHandler.Removed redundant address validation.Updated responses to use types.TxsResponse for consistency.Removed the obsolete getBlockHeight function, as it is no longer needed.
@github-actions
Copy link

This repository does not accept pull requests from non version branches.
--- Please CLOSE this PR after acknowledging the issue ---

@github-actions github-actions bot added the invalid This doesn't seem right label Jan 27, 2025
@github-actions github-actions bot locked as spam and limited conversation to collaborators Jan 27, 2025
@golnar-boosty golnar-boosty requested a review from MrLutik January 27, 2025 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants