Skip to content

Added a Basic Log Viewer#40

Open
iggi- wants to merge 3 commits intoKissaki:masterfrom
iggi-:master
Open

Added a Basic Log Viewer#40
iggi- wants to merge 3 commits intoKissaki:masterfrom
iggi-:master

Conversation

@iggi-
Copy link

@iggi- iggi- commented Dec 4, 2013

Added a basic log viewer which is able to display a paginated list of the log entries with timestamps and their respective log text.

Eric Knific added 3 commits December 4, 2013 00:26
…ilable.

Changed the default # of results setting and results options to suit smaller as well as larger servers.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other two cases $results is calculated through $last = $first+$results;, which it could also be here.
That makes it a common calculation that should be made below the if, else if, else - as a common code-path.

@Kissaki
Copy link
Owner

Kissaki commented Dec 4, 2013

There seem to be some formatting issues in general. In general formatting should be consistent with the code around it.
In githubs diff view here you can clearly see indentation issues; did you use tabs rather than spaces (at times)?

@Kissaki
Copy link
Owner

Kissaki commented Dec 4, 2013

Went through it. Seems good.
Thanks for providing this PR! :)
Did not test it yet runtime-wise - just checked the code.

@iggi-
Copy link
Author

iggi- commented Dec 12, 2013

Sorry for the delay, I should have some time this weekend to go over the changes and make corrections as needed.

@Kissaki
Copy link
Owner

Kissaki commented Jul 26, 2014

@iggi- What’s the status? Did you have some time? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants