Fix mobile contact icon tap glitch and label contrast#1
Open
shamith16 wants to merge 3 commits intoKitchenEngineer1332:mainfrom
Open
Fix mobile contact icon tap glitch and label contrast#1shamith16 wants to merge 3 commits intoKitchenEngineer1332:mainfrom
shamith16 wants to merge 3 commits intoKitchenEngineer1332:mainfrom
Conversation
Tapping a contact icon (e.g. GitHub, Instagram) was bubbling up to the parent box click handler, causing the section to lock/unlock and creating a visual glitch on mobile. Added a guard to skip the lock logic when the click originates from a contact icon.
Changed icon label color from white to dark red (--accent-red-deep) for readable contrast against the sand background. White color and text-shadow now only apply on hover when the colored background is present. Replaced the expand-all-on-box-active behavior with an individual .expanded class for touch devices, and removed the brief :active pseudo-class that was barely visible on tap.
Replaces the expand-all-on-section-tap mobile behavior with a per-icon tap interaction that matches desktop hover UX: first tap expands the icon and reveals its label, second tap navigates to the link. Tapping outside or on another icon collapses the previous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.