Frontend/user metrics currency conversion fix#173
Merged
Conversation
…ng to bed... its 4am..
Added a new file to cache the currencies and now it fully works across the whole system
All user metrics are now connected
Collaborator
|
Awesome, thanks for getting to this Kithe, I'm sure we could've made it work with Rupees but I am definitely glad we don't have to. The metrics look great for your individual, good work! All tests passed. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished the user metrics feature
corrected the currency functionality across the whole system, by implementing a caching system