add universal model for Neo Ya #465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenguoguo
reviewed
Jul 5, 2018
Collaborator
chenguoguo
left a comment
chenguoguo
left a comment
There was a problem hiding this comment.
Please check the comments. Also, does the model compatible with the current libraries on github?
README.md
Outdated
| * **resources/models/jarvis.umdl**: Universal model for the hotword "Jarvis" (https://snowboy.kitt.ai/hotword/29). It has two different models for the hotword Jarvis, so you have to use two sensitivites. Set sensitivities to "0.8,0.80" and ApplyFrontend to true. | ||
| * **resources/models/jarvis.umdl**: Universal model for the hotword "Jarvis" (https://snowboy.kitt.ai/hotword/29). It has two different models for the hotword Jarvis, so you have to use two sensitivites. Set sensitivities to "0.8, 0.8" and ApplyFrontend to true. | ||
| * **resources/models/smart_mirror.umdl**: Universal model for the hotword "Smart Mirror" (https://snowboy.kitt.ai/hotword/47). Set sensitivity to Sensitivity to 0.5, and ApplyFrontend to false. | ||
| * **resources/models/neo_ya.umdl**: Universal model for the hotword "Neo Ya" (https://snowboy.kitt.ai/hotword/22171). It has four different models for the hotword "Neo Ya", so you have to use two sensitivites "0.6, 0.6, 0.6, 0.6", and ApplyFrontend to true. |
Collaborator
There was a problem hiding this comment.
No space between sensitivities.
README.md
Outdated
| * **resources/alexa/alexa-avs-sample-app/alexa.umdl**: Universal model for the hotword "Alexa" optimized for [Alexa AVS sample app](https://github.com/alexa/alexa-avs-sample-app). Set SetSensitivity to 0.6, and set ApplyFrontend to true. This is so far the best "Alexa" model we released publicly, when ApplyFrontend is set to true. | ||
| * **resources/models/snowboy.umdl**: Universal model for the hotword "Snowboy". Set SetSensitivity to 0.5 and ApplyFrontend to false. | ||
| * **resources/models/jarvis.umdl**: Universal model for the hotword "Jarvis" (https://snowboy.kitt.ai/hotword/29). It has two different models for the hotword Jarvis, so you have to use two sensitivites. Set sensitivities to "0.8,0.80" and ApplyFrontend to true. | ||
| * **resources/models/jarvis.umdl**: Universal model for the hotword "Jarvis" (https://snowboy.kitt.ai/hotword/29). It has two different models for the hotword Jarvis, so you have to use two sensitivites. Set sensitivities to "0.8, 0.8" and ApplyFrontend to true. |
Collaborator
There was a problem hiding this comment.
Please remove the space between the numbers, only use ",". The reason is that we interpret the sensitivities as a string in C++, and we use "," as the delimiter.
README_ZH_CN.md
Outdated
| * **resources/models/snowboy.umdl**：唤醒词为“snowboy”的通用模型。将`SetSensitivity`设置为`0.5`，`ApplyFrontend`设置为`false`。 | ||
| * **resources/models/jarvis.umdl**: 唤醒词为“Jarvis” (https://snowboy.kitt.ai/hotword/29)的通用模型，其中包含了对应于“Jarvis”的两个唤醒词模型，所以需要设置两个`sensitivity`。将`SetSensitivity`设置为`0.8,0.8`，`ApplyFrontend`设置为`true`。 | ||
| * **resources/models/smart_mirror.umdl**: 唤醒词为“Smart Mirror” (https://snowboy.kitt.ai/hotword/47)的通用模型。将`SetSensitivity`设置为`0.5`，`ApplyFrontend`设置为`false`。 | ||
| * **resources/models/neo_ya.umdl**: 唤醒词为"Neo Ya" (https://snowboy.kitt.ai/hotword/22171)的通用模型，其中包含了对应于"Neo Ya"的四个唤醒词模型, 所以需要设置四个`sensitivites`。将`SetSensitivity`设置为`0.6, 0.6, 0.6, 0.6`，`ApplyFrontend`设置为`true`。 |
Collaborator
There was a problem hiding this comment.
No space between sensitivities.
Author
|
I have removed the whitespace between sensitivities. Besides, the model is compatible with the current libraries |
chenguoguo
reviewed
Jul 7, 2018
README.md
Outdated
| * **resources/models/jarvis.umdl**: Universal model for the hotword "Jarvis" (https://snowboy.kitt.ai/hotword/29). It has two different models for the hotword Jarvis, so you have to use two sensitivites. Set sensitivities to "0.8,0.80" and ApplyFrontend to true. | ||
| * **resources/models/jarvis.umdl**: Universal model for the hotword "Jarvis" (https://snowboy.kitt.ai/hotword/29). It has two different models for the hotword Jarvis, so you have to use two sensitivites. Set sensitivities to "0.8,0.8" and ApplyFrontend to true. | ||
| * **resources/models/smart_mirror.umdl**: Universal model for the hotword "Smart Mirror" (https://snowboy.kitt.ai/hotword/47). Set sensitivity to Sensitivity to 0.5, and ApplyFrontend to false. | ||
| * **resources/models/neo_ya.umdl**: Universal model for the hotword "Neo Ya" (https://snowboy.kitt.ai/hotword/22171). It has four different models for the hotword "Neo Ya", so you have to use two sensitivites "0.6,0.6,0.6,0.6", and ApplyFrontend to true. |
Collaborator
There was a problem hiding this comment.
"so you have to use two sensitivities" --> "so you have to use four sensitivities"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a universal model for the keyword "Neo Ya". There are 4 models in the .umdl file, and the suggested sensitivities are [0.6, 0.6, 0.6, 0.6].