Add camera matrix helpers #8755
Draft
+134
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows creation of view and projection matrices that are consistent with what's used in engine
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewvarga
reviewed
Nov 3, 2025
| width, | ||
| -height, | ||
| height, | ||
| -farClip, |
There was a problem hiding this comment.
Shouldn't this be using Oh, I just saw the comment above.nearClip?
There was a problem hiding this comment.
Yeah, it's a sneaky trick to allow "infinite" zoom in ortho mode.
andrewvarga
reviewed
Nov 3, 2025
| aspectRatio: number, | ||
| nearClip: number, | ||
| farClip: number, | ||
| coordSystem: CoordinateSystem = WebGLCoordinateSystem |
There was a problem hiding this comment.
Will we be able get the coordSystem from the engine? Or for now we can just assume WebGL
There was a problem hiding this comment.
That should be determined by the active renderer on the FE (assumed WebGL).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some helper functions for creating camera matrices from
CameraViewStatethat are consistent with what's used in engine. Hoping this helps correct some of the inconsistencies we're seeing in #8737.