Skip to content

fix(nix): skip test compilation in Nix build 🔧#33

Merged
Klazomenai merged 1 commit intomainfrom
fix/nix-docheck
Mar 28, 2026
Merged

fix(nix): skip test compilation in Nix build 🔧#33
Klazomenai merged 1 commit intomainfrom
fix/nix-docheck

Conversation

@Klazomenai
Copy link
Copy Markdown
Owner

Summary

  • Add doCheck = false to buildRustPackage in flake.nix
  • E2E tests use include_str! to read Foundry artifacts (contracts/out/) which aren't available in the Nix sandbox
  • Tests run via CI, not during Nix image builds

Refs #9

Test plan

  • nix build .#alpha-image succeeds
  • Image pushed to ghcr.io/klazomenai/keyra/alpha:latest

E2E tests require Foundry artifacts (contracts/out/) which aren't
available in the Nix sandbox. Tests run via CI, not during Nix build.

Refs #9
@Klazomenai Klazomenai self-assigned this Mar 27, 2026
@Klazomenai Klazomenai marked this pull request as ready for review March 27, 2026 14:26
Copilot AI review requested due to automatic review settings March 27, 2026 14:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Nix flake to make nix build .#alpha-image succeed by skipping Rust test execution during the Nix build, since E2E tests depend on generated Foundry artifacts (contracts/out/) that aren’t available in the Nix sandbox.

Changes:

  • Disable the checkPhase for the Rust buildRustPackage derivation by setting doCheck = false.
  • Add an explanatory comment documenting why Nix checks are disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Klazomenai Klazomenai merged commit 58c18d1 into main Mar 28, 2026
9 checks passed
@Klazomenai Klazomenai deleted the fix/nix-docheck branch March 28, 2026 10:21
Klazomenai added a commit that referenced this pull request Mar 28, 2026
Replace doCheck = false with cargoTestFlags to run unit and integration
tests during Nix builds while skipping E2E tests that require Foundry
artifacts (contracts/out/). PR #33 merged the original doCheck = false
before this fix could be pushed.

Refs #9
Klazomenai added a commit that referenced this pull request Mar 28, 2026
Replace doCheck = false with cargoTestFlags to run unit and integration
tests during Nix builds while skipping E2E tests that require Foundry
artifacts (contracts/out/). PR #33 merged the original doCheck = false
before this fix could be pushed.

Refs #9
Klazomenai added a commit that referenced this pull request Mar 28, 2026
Replace doCheck = false with cargoTestFlags to run unit and integration
tests during Nix builds while skipping E2E tests that require Foundry
artifacts (contracts/out/). PR #33 merged the original doCheck = false
before this fix could be pushed.

Refs #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants