Avoid calling very slow steady_clock::now #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Unfortunately, steady_clock calls in WASM translate to native JS calls, which bottlenecks simfil in the browser in extreme ways: The steady_clock calls cause a roughly 69% slowdown, maybe more, both on Chrome and Firefox. E.g. in a heavy tile render call we spend 115ms in simfil eval; 80ms of this time are spent in the emscripten steady_clock implementation!
On the Desktop, the impact is just 10%, but still worth it.
For completion (i.e. when a timeout is set), we need to consider a different implementation. For example, we could check the timeout in-between evals for individual features in the WASM workers, not for each Expr eval in simfil.
Note
Cursor Bugbot is generating a summary for commit 1fdbf28. Configure here.