feat(translate-selection): improve controls and popup stability#12
Merged
bingran-you merged 7 commits intomasterfrom Jan 28, 2026
Merged
feat(translate-selection): improve controls and popup stability#12bingran-you merged 7 commits intomasterfrom
bingran-you merged 7 commits intomasterfrom
Conversation
…sitioning - Add 3-column grid layout for swap button between language dropdowns - Add swap button styling with hover/disabled states - Change button layout to space-between (Clear left, Copy+Translate right) - Add actions-right wrapper for grouped buttons - Fix translate button padding for even spacing
- Increase swap icon size from 16px to 20px with font-weight 600 - Add symmetric padding to header button for hover state breathing room - Increase button min-width to 85px to fit "Translating..." text
- Swap arrows: font-size 20px → 24px, font-weight 600 → normal - Header button: margin-left 0 → -8px to align T with label below
The CSS expects colors and tool-toggle to be wrapped in a .selection-popup-row div for proper flex layout. Without this wrapper, the CSS rules for same-row display don't apply. This fixes: - Colors and highlight/underline toggle now on same row - Proper flex layout enables correct dropdown positioning
Add 'select' to the whitelist of elements that don't have preventDefault() called on pointerdown. Without this, clicking a <select> element blocks the native dropdown from opening.
Adds min-width: 120px to .deeptutor-translate-select to prevent layout reflow when native <select> dropdowns are first opened. This stabilizes popup positioning on first interaction.
thokap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing