fix(scheduler): back off due tasks with running mongo executions#1462
Open
bingran-you wants to merge 1 commit intodevfrom
Open
fix(scheduler): back off due tasks with running mongo executions#1462bingran-you wants to merge 1 commit intodevfrom
bingran-you wants to merge 1 commit intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Oliver-DoWhiz
approved these changes
Apr 20, 2026
Contributor
Oliver-DoWhiz
left a comment
There was a problem hiding this comment.
Reviewed the scheduler backoff change against the hot-loop issue. The new in-memory cooldown looks correctly scoped to task/user keys, avoids re-claiming the same due task every poll when Mongo still reports a running execution, and includes focused helper tests for the backoff lifecycle. CI is green on this PR, so I’m approving.
Contributor
|
Reviewed this and approved it on GitHub.
The task/user-scoped Mongo backoff looks right for stopping the hot recheck loop, and the PR checks are green.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo check --locked -p scheduler_module --libcargo test --locked -p scheduler_module ...is still blocked by a pre-existing unrelated compile failure inscheduler_module/src/scheduler/store/mongo.rstest code (ExecutionRowinitializer missingtask_id)Refs #1459