fix(debug_archive): surface actual upload error, collapse per-target spam#1492
Open
bingran-you wants to merge 1 commit intodevfrom
Open
fix(debug_archive): surface actual upload error, collapse per-target spam#1492bingran-you wants to merge 1 commit intodevfrom
bingran-you wants to merge 1 commit intodevfrom
Conversation
…line The primary task_debug_archive upload target on production fails on every task (observed 6818+ entries over ~5 hours), but a fallback target succeeds so the archive still lands. The per-target Err(_) arm dropped the underlying SchedulerError and printed a generic "attempt failed" line for each try, hiding the root cause (likely SAS token permissions) and spamming stderr. Collect attempt errors and only print a single line after all targets fail, including the actual SchedulerError message for each attempt. Refs #1488
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dw_workerwhere everytask_debug_archiveupload emitted a generic[task_debug_archive] upload attempt failed ...line for each attempted target (observed 6818+ entries in ~5h on production), while the root causeSchedulerErrorwas discarded byErr(_).Closes #1488
Behaviour before
Behaviour after
Test plan
cargo test -p scheduler_module --lib scheduler::debug_archive— 4/4 passcargo check -p scheduler_moduledowhizprod1thattask_debug_archivelog noise drops to ~0 while Mongotask_debug_archives.status="uploaded"counts stay steady.