Circuit breaker for Google Workspace comment poller (#1490)#1494
Open
bingran-you wants to merge 2 commits intodevfrom
Open
Circuit breaker for Google Workspace comment poller (#1490)#1494bingran-you wants to merge 2 commits intodevfrom
bingran-you wants to merge 2 commits intodevfrom
Conversation
Google's comments API occasionally returns sticky 5xx errors for specific files (observed on a staging presentation: permanent 500 internalError). The poller runs list_comments every cycle, so those files produced continuous log spam and wasted API quota. Introduce CommentCircuitBreaker keyed on file_id: - After 5 consecutive list_comments failures, skip that file for an exponentially growing cooldown window (1m, 2m, 4m ... capped at 30m). - Elevated warn emitted at trip time and then at most once per hour while the breaker stays open. - Any success immediately resets state. Applied to all three pollers (Docs, Sheets, Slides) since they share the same failure mode. Refs #1490
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1490
Test plan