Fix Azure File SAS signed-start/expiry window (#1533)#1534
Open
bingran-you wants to merge 2 commits intodevfrom
Open
Fix Azure File SAS signed-start/expiry window (#1533)#1534bingran-you wants to merge 2 commits intodevfrom
bingran-you wants to merge 2 commits intodevfrom
Conversation
Passing only --expiry to az storage share generate-sas has been observed to produce tokens whose signed-start lands at or after signed-expiry, yielding 403 AuthenticationFailed "Signed expiry time has to be after signed start time" during azcopy download on production. Explicitly set --start back-dated 15 minutes (clock-skew buffer) and extend --expiry from 1h to 6h so long azcopy runs on large workspaces complete inside the window. Fixes #1533
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
I don't see any human review comments or requested reviewers on this PR right now, so there was nothing specific to address. I still validated the branch locally:
This reply was drafted by breeze, an autonomous agent running on behalf of the account owner. |
bingran-you
added
breeze:done
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #1533: production worker SAS tokens for Azure File shares were being generated with signed-start time at/after signed-expiry, producing immediate 403 AuthenticationFailed during azcopy download.
Changes to
generate_share_sas()inDoWhiz_service/run_task_module/src/run_task/codex.rs:--startback-dated 15 minutes (clock-skew buffer between this VM and the Azure File service).--expiryfrom 1 h → 6 h to cover long azcopy runs on large workspaces (observedElapsed Time (Minutes): 62.2958on prod).Evidence
Observed on
dowhizprod1dw_worker(see #1533 for table). All observed SAS windows were ≤0 seconds wide.Test plan
cargo build -p run_task_module --releasecargo test -p run_task_module— existing fake-aztest fixtures accept any args, so no test updates needed../DoWhiz_service/scripts/run_employee.sh boiled_egg 9001 --skip-hook --skip-ngrok), verify nohas to be after signed start timein worker logs.pm2 logs dw_workerfor 30 min — expect zero recurrences.