Skip to content

chore(ts): lint-driven type-safety hardening across engine/forge#76

Draft
th3w1zard1 wants to merge 1 commit intoKobaltBlu:masterfrom
th3w1zard1:cosmetic-only-upstream
Draft

chore(ts): lint-driven type-safety hardening across engine/forge#76
th3w1zard1 wants to merge 1 commit intoKobaltBlu:masterfrom
th3w1zard1:cosmetic-only-upstream

Conversation

@th3w1zard1
Copy link
Contributor

@th3w1zard1 th3w1zard1 commented Feb 28, 2026

Summary

This PR applies a broad lint/type-safety hardening pass across KotOR.js and Forge codepaths.

Primary purpose

  • Reduce unsafe typing patterns flagged by TypeScript ESLint (especially no-unsafe-* families).
  • Replace loosely typed error handling with explicit unknown catch parameters and safer narrowing patterns.
  • Add/propagate stronger explicit types in hotspots where implicit/any-like flows surfaced.

Secondary refactors included in the same pass

  • Normalize import paths toward alias-based @/ imports for consistency.
  • Standardize logging to scoped logger usage (createScopedLogger) and remove ad-hoc console-style usage.
  • Apply lint-driven cleanup changes (unused parameter prefixing like _delta, minor const/signature tidy-ups).

Scope notes

  • Large mechanical refactor touching many files across src/actions, src/apps/forge, engine/runtime, and related utilities.
  • Intent is code health and static-safety improvement; behavior changes are not the goal.

Validation

  • Updated from generated diff artifacts and reviewed for dominant change patterns in this branch.
  • Main risk is regression from broad churn; recommended follow-up is targeted smoke checks in Forge editors and core runtime flows.

@th3w1zard1 th3w1zard1 marked this pull request as draft February 28, 2026 05:17
@th3w1zard1 th3w1zard1 changed the title chore: apply cosmetic-only cleanup from upstream diff chore(ts): lint-driven type-safety hardening across engine/forge Feb 28, 2026
@th3w1zard1 th3w1zard1 force-pushed the cosmetic-only-upstream branch from f6a3f81 to 3cb7076 Compare February 28, 2026 05:34
@KobaltBlu KobaltBlu self-requested a review February 28, 2026 11:22
@KobaltBlu KobaltBlu force-pushed the cosmetic-only-upstream branch from 3cb7076 to ebb2da1 Compare February 28, 2026 13:38
@KobaltBlu
Copy link
Owner

@th3w1zard1, the import alias map appears to be missing from this pull request. Please review your code and make the necessary changes, and I will continue my review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants