This repository was archived by the owner on Dec 11, 2025. It is now read-only.
chore: utilize Kong forks for gopher-lua and gopher-json #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikefero
force-pushed
the
chore/use-kong-forks
branch
from
f04cf77 to
d0d72c0
Compare
Contributor
|
Hoping yuin/gopher-lua#421 addresses the |
omegabytes
previously approved these changes
Dec 16, 2022
Contributor
Author
LOL ... Nope, we will have to implement that ourselves. I am hoping that this change goes upstream and then we can remove the replaces in the future, |
This update required a change to the Option used for the Lua filesystem. The option was changed from FS => LuaFileSystem.
This update required two changes to encode Lua userdata and JSON null values and support the encoding of sparsed arrays.
mikefero
force-pushed
the
chore/use-kong-forks
branch
from
d0d72c0 to
4371277
Compare
GGabriele
approved these changes
Dec 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
goksto use Kong repo forks for gopher-lua and gopher-json. The custom changes the Kong repo forks provide have also been submitted to both projects in order for us to remove the replace functions ensuring easier updates to these dependencies in the futurekong/gopher-lua is pointing to
embeded-lua-filesystem(what horrible spelling there) and kong/gopher-json is pointing toencode-sparse-arraysNote: gopher-lua has had a lot of activity since
goksfirst started which means that the Kong fork has received these updates as well.