Auto-detect graylog leader and remove kubectl download#161
Merged
KongZ merged 4 commits intoKongZ:mainfrom Jun 6, 2024
Merged
Conversation
metron2
force-pushed
the
feature/kubectl_only_for_older_releases
branch
2 times, most recently
from
0c4fb5b to
8ca7323
Compare
…a_dir for graylog 6 Signed-off-by: metron2 <derek.griffiths@cyber.gc.ca>
metron2
force-pushed
the
feature/kubectl_only_for_older_releases
branch
from
8ca7323 to
ecfb4cf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: metron2 <derek.griffiths@cyber.gc.ca>
…der for leader detection to work Signed-off-by: metron2 <derek.griffiths@cyber.gc.ca>
Contributor
Author
|
I realized the chart is using a custom entry point so it just needed the same logic as the main docker image has. |
metron2
changed the title
KongZ
reviewed
Jun 5, 2024
Signed-off-by: metron2 <metron2@users.noreply.github.com>
KongZ
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This cleans up the code in #154 - removing the kubectl volume, download and semver check
Which issue this PR fixes
Graylog 6 adds a new data_dir requirement, which is set. I don't believe this will cause problems for older graylog
Special notes for your reviewer
Checklist