Fix incorrect loading of Oktalyzer order list. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Nov 29, 2020
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Jun 12, 2021
AliceLR
added a commit
to AliceLR/libmodplug
that referenced
this pull request
Jun 18, 2021
Contributor
Author
|
Since this has been combined into #58, which is just about ready for review, I'm going to go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header for the Oktalyzer PATT IFF chunk is 8 bytes long, but libmodplug starts loading the order list from offset 10, causing it to drop the first two orders of any Oktalyzer module. Source: https://modland.com/pub/documents/format_documentation/Oktalyzer%20(.okta).txt
Test files:
black_box.okt.zip
distortion.okt.zip