fix(agent,tests): address review findings #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Koopa0
commented
Dec 22, 2025
Koopa0
commented
- Complete deep copy with honest naming (shallowCopyMap)
- Improve test assertions (RAG, LLM memory, tool verification, token order)
- Add clarifying documentation for test limitations
- Expand multilingual fuzz coverage (+7 languages)
- Fix golangci-lint config (remove invalid sloglint.key-naming-case)
- Sync CI golangci-lint version to 2.7.1
- Complete deep copy with honest naming (shallowCopyMap)
- Improve test assertions (RAG, LLM memory, tool verification, token
order)
- Add clarifying documentation for test limitations
- Expand multilingual fuzz coverage (+7 languages)
- Fix golangci-lint config (remove invalid sloglint.key-naming-case)
- Sync CI golangci-lint version to 2.7.1
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
Comment on lines
213
to
215
| response := strings.ToLower(resp.FinalText) | ||
| hasMultipleAspects := (strings.Contains(response, "concurrent") || strings.Contains(response, "goroutine")) && | ||
| (strings.Contains(response, "simple") || strings.Contains(response, "readab")) && |
There was a problem hiding this comment.
The substring matching in hasMultipleAspects is somewhat fragile and may lead to flaky tests if the LLM output changes or uses synonyms not covered by the current checks. Consider expanding the set of synonyms or using a more robust method for semantic matching if test flakiness becomes an issue. For now, the trade-off is documented, but be aware of potential maintenance overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.