fix: resolve TUI test compilation and database migration issues #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Koopa0
commented
Dec 22, 2025
Koopa0
commented
- Update TUI tests for new function signatures
- Make database migrations idempotent with IF NOT EXISTS
- Fixes CI failures from dirty database state
- Update TUI tests for new function signatures - Make database migrations idempotent with IF NOT EXISTS - Fixes CI failures from dirty database state
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| CREATE TABLE IF NOT EXISTS documents ( | ||
| id TEXT PRIMARY KEY, | ||
| content TEXT NOT NULL, | ||
| embedding vector(768) NOT NULL, -- text-embedding-004 dimension |
There was a problem hiding this comment.
The embedding column is defined as vector(768), which hardcodes the embedding dimension. This reduces flexibility if you switch to a different embedding model with a different dimension in the future. Consider parameterizing the dimension or documenting the migration process for changing the dimension to improve maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.