fix: resolve CI test failures #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Koopa0
commented
Dec 22, 2025
Koopa0
commented
- Make database migrations idempotent with IF NOT EXISTS
- Fix TUI test function signature mismatches
- Add project root detection for prompts directory in cmd tests
- Fix chat.Config field names in TUI setup
- Make database migrations idempotent with IF NOT EXISTS - Fix TUI test function signature mismatches - Add project root detection for prompts directory in cmd tests - Fix chat.Config field names in TUI setup
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| @@ -219,13 +219,14 @@ func setupChatFlow(t *testing.T) (*chatFlowSetup, func()) { | |||
| // Combine all tools | |||
| allTools := append(append(fileTools, systemTools...), knowledgeTools...) | |||
There was a problem hiding this comment.
Potential maintainability issue with nested append calls
The aggregation of tool slices using nested append calls:
allTools := append(append(fileTools, systemTools...), knowledgeTools...)can become error-prone and less readable as the number of tool groups increases or if any of the slices are nil. Consider using a single flat append with variadic arguments or a helper function to improve clarity and reduce the risk of subtle bugs:
allTools := make([]tools.Tool, 0, len(fileTools)+len(systemTools)+len(knowledgeTools))
allTools = append(allTools, fileTools...)
allTools = append(allTools, systemTools...)
allTools = append(allTools, knowledgeTools...)This approach is more maintainable and explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.