Suppress readExcel StatusLogger from log4j in 2025.2.4 notebooks #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
fix-log4j-error
branch
from
179fc5f to
697029b
Compare
Jolanrensen
reviewed
Nov 28, 2025
| } | ||
|
|
||
| // Needed to suppress ERROR Log4j API could not find a logging provider in 2025.2.4 | ||
| loadLog4jIntoNotebookClasspath(notebook) |
Collaborator
There was a problem hiding this comment.
Does calling this function in 2025.3+ cause any issues? Or could it cause issues in the future?
As it's only meant for 2025.2-. Can we somehow check which version the notebook is running and only call it if it's necessary?
Collaborator
Author
There was a problem hiding this comment.
Does calling this function in 2025.3+ cause any issues? Or could it cause issues in the future?
No, StatusLogger is suppressed by notebooks there. I don't think this issue will reappear
Can we somehow check which version the notebook is running and only call it if it's necessary?
We have KotlinNotebookPluginUtils.IdeBuildNumber. I'll try
Collaborator
Author
|
Update: after testing again fix doesn't work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message doesn't appear in 2025.3 anymore, but for 2025.2.+ fix is needed. Let's agree if we want it