Skip to content

Removed gradle plugin application tests for JS legacy backend #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Removed gradle plugin application tests for JS legacy backend #284

wants to merge 1 commit into from

Conversation

mvicsokolova
Copy link
Collaborator

@mvicsokolova mvicsokolova commented Mar 17, 2023 •
edited
Loading

Removed atomicfu-gradle-plugin project tests for JS legacy backend.

@mvicsokolova mvicsokolova requested a review from qwwdfsad March 17, 2023 11:35
qwwdfsad
qwwdfsad reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate on the overall reasoning of this change?

@mvicsokolova
Copy link
Collaborator Author

Actually, there was a wrong motivation for these changes, the build of master failed with an error Could not find org.nodejs:node:16.13.0 -- nothing to do with js legacy backend. So, It's not necessary to merge it now, we can do it when legacy JS backend will be deprecated in Kotlin 1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvicsokolova @qwwdfsad