Remove findProperty to support ProjectIsolation #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrasnoff
reviewed
Dec 3, 2024
| @@ -170,7 +170,7 @@ private fun KotlinVersion.atLeast(major: Int, minor: Int, patch: Int) = | |||
| private fun Project.isCompilerPluginAvailable() = getKotlinVersion().atLeast(1, 6, 20) | |||
|
|
|||
| internal fun Project.getBooleanProperty(name: String) = | |||
| rootProject.findProperty(name)?.toString()?.toBooleanStrict() ?: false | |||
| providers.gradleProperty(name).orNull?.toBooleanStrict() ?: false | |||
There was a problem hiding this comment.
It is also worth looking into ExtraPropertiesExtension extension
There was a problem hiding this comment.
What exactly do you mean? AFAIK, you should avoid the (untyped) ext api too.
There was a problem hiding this comment.
findProperty could previously look through extra properties.
And I mean from the 'less breaking change' point of view we should support ext as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.