Kotlin 2.3 #3112
Open
Kotlin 2.3 #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix some test dependencies due to "Adding API dependency types to test source sets is not supported and will removed in a future version of Kotlin." warning. - Update BCV version
fzhinkin
approved these changes
Nov 17, 2025
Contributor
fzhinkin
left a comment
fzhinkin
left a comment
There was a problem hiding this comment.
Overall, the change looks good. There are only a few minor nits from me.
| freeCompilerArgs.add("-Xsuppress-version-warnings") | ||
| } | ||
| freeCompilerArgs.add("-Xexpect-actual-classes") | ||
| // for some reason, IDE does not enable feature in test source sets without this line: |
Contributor
There was a problem hiding this comment.
Could you please file an issue to investigate the root cause further?
| val str = json.encodeToString(Sealed.serializer(), outer) | ||
| // throw-away data | ||
| json.decodeFromString(Sealed.serializer(), str) | ||
| // check that data is correctly formed |
Contributor
There was a problem hiding this comment.
[nit] If the goal is to check correctness, should we validate that deserialized object is structurally equal to outer?
| } | ||
| } | ||
|
|
||
| @IgnorableReturnValue |
Contributor
There was a problem hiding this comment.
Should the function has Unit as its return type instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some test dependencies due to "Adding API dependency types to test source sets is not supported and will removed in a future version of Kotlin." warning.
Update BCV version
Enable Unused Return Value checker