Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the API key hashing mechanism in the authentication service from HMAC-SHA256 to scrypt, enhancing security by making hashes more resistant to brute-force attacks. It also updates related environment variables, error handling, and test cases to reflect this change.
Security improvements (API key hashing):
AuthService(auth.service.ts), including updating thehashKeymethod and related documentation/comments.auth.service.spec.ts). [1] [2] [3] [4]Configuration and error handling:
KK_HMAC_SECRETto.env.examplewith instructions for generating a secure secret, and improved error/warning messages if the secret is missing during initialization or service key seeding (.env.example,auth.service.ts). [1] [2] [3]These changes collectively improve the security and reliability of API key management in the authentication service.