Create scaffold for LiteRecord by henrystivens · Pull Request #58 · KumbiaPHP/Koot

henrystivens · 2025-04-18T23:54:07Z

No description provided.

The MySQL schema previously named `ku_admin` has been renamed to `koot`. This includes modifications to the schema and table names, adjusting primary key, unique index, and foreign key constraints to reflect the new schema name.

Updates the admin navigation links to include trailing slashes. This ensures consistent routing and proper resource loading. The "Roles" link has been removed.

Improves accessibility by adding aria-label attributes to the navigation elements.

Removes the unused create views for resources and users. These views are no longer needed and are being removed to clean up the codebase.

Refactors scaffold creation and editing to use ModelLiteForm. This change introduces a new class `ModelLiteForm` for generating HTML forms based on model metadata. It simplifies the controller logic and provides a more flexible and maintainable way to create forms. The changes also ensure that form data persists on validation failure and includes necessary HTML escaping for security.

Create scaffold

Removes the dedicated view for creating roles within the admin panel. This change may be part of a broader refactoring or simplification of role management functionality.

Ensures correct navigation to the admin users page by adding a trailing slash to the URL in the navigation links. This resolves an issue where the admin users page was not being loaded correctly.

Ensures email uniqueness during user creation and updates to prevent duplicate accounts. Adds checks in `_beforeCreate` and `_beforeUpdate` methods to validate email existence against the database.

Adds session management to the admin controller. This ensures user sessions are properly handled within the administrative interface.

Sets SQLite as the default database configuration. This change simplifies initial setup and is more suitable for development environments.

Updates the default SQLite database file name from `ku_admin.db` to `koot.db` for clarity and consistency.

Ensures correct navigation to the admin users page by adding a trailing slash to the URL in the navigation links. This resolves an issue where the admin users page was not being loaded correctly.

Ensures type safety by explicitly declaring the model property as a string.

Updates the Koot CSS file to reflect the 2025 version.

Improves the data display in tables by ensuring that the "No records" message is displayed correctly when no data is available. Also, ensures the return statement does not interfere with the rendering of the rest of the page.

Corrects an issue where the conditional `endif` statement was not properly placed, potentially causing rendering errors. This change ensures the conditional logic functions as intended.

Enhances the appearance of the "Record not found" page actions by applying Bootstrap button styles, improving usability and visual appeal.

Corrects the conditional statement to properly check if the `$data` variable is not set or if it contains no records.

Ensures the "Record not found" message is properly translated by using the correct PHP syntax for outputting the translated string.

Adds a static `escape` function to handle HTML escaping for user-provided values. This prevents potential cross-site scripting (XSS) vulnerabilities by ensuring that all outputted strings are properly sanitized. Uses the `escape` function to sanitize primary key values, field values, and select options. Checks if model properties are set before accessing them to avoid undefined property errors.

Copilot

Pull Request Overview

This PR creates a scaffold system for the "LiteRecord" ORM pattern in the Koot framework, transitioning from manual admin views to an automated form generation system. The changes introduce a new form builder class and update existing scaffolding components to use this new approach.

Key changes:

Introduces ModelLiteForm class for automatic HTML form generation from LiteRecord models
Updates scaffold controller logic to use dynamic model properties and improve error handling
Creates new lite scaffold templates that leverage the form builder
Updates database configuration and schema from ku_admin to koot

Reviewed Changes

Copilot reviewed 18 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`koot/libs/model_lite_form.php`	New form builder class that generates HTML forms from LiteRecord model metadata
`koot/libs/controller_scaffold_lite.php`	Updated scaffold controller with improved data handling and error management
`koot/views/_shared/scaffolds/lite/create.phtml`	New create form template using the ModelLiteForm builder
`koot/views/_shared/scaffolds/lite/show.phtml`	Fixed syntax errors and improved localization
`koot/views/_shared/scaffolds/lite/page.phtml`	Fixed logical condition and syntax errors
`koot/models/users.php`	Added validation logic for unique email constraints
`koot/config/mysql/koot.sql`	New database schema replacing the old `ku_admin` structure
Various admin view files	Removed manual form templates in favor of scaffold system

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-20T15:58:35Z

koot/views/_shared/scaffolds/lite/create.phtml

@@ -0,0 +1,12 @@
+<div id="scaffold">
+    <?php View::content() ?>
+    <h1><?= ucwords("$model"), ": <span>$action_name</span>" ?></h1>


The comma operator is incorrectly used in the echo statement. It should use concatenation (.) instead of comma to properly combine the strings.

Suggested change

<h1><?= ucwords("$model"), ": <span>$action_name</span>" ?></h1>

<h1><?= ucwords("$model") . ": <span>$action_name</span>" ?></h1>

Copilot · 2025-08-20T15:58:36Z

koot/libs/controller_scaffold_lite.php

+            // Success message and return to the list
+            Flash::valid(_('Record created'));
+            Redirect::toAction('');
+            return;


The logic is inverted. The condition should check if creation succeeds (without the '!' operator) to show success message and redirect.

Suggested change

return;

if ($obj->create(Input::post($this->model))) {

// Success message and return to the list

Flash::valid(_('Record created'));

Redirect::toAction('');

return;

} else {

Flash::error(_('Something was wrong'));

// If it fails the data is persistent in the form

$this->{$this->model} = $obj;

return;

}

Copilot · 2025-08-20T15:58:36Z

koot/libs/controller_scaffold_lite.php

-                // Success message and return to the list
-                Flash::valid(_('Record updated'));
-                Redirect::toAction('');
+            if (!$this->{$this->model}->update(Input::post($this->model))) {


The logic is inverted. The condition should check if update succeeds (without the '!' operator) to show success message and redirect.

Copilot · 2025-08-20T15:58:36Z

koot/libs/model_lite_form.php

+
+        // If the field ends with '_id', use a database select
+        if (str_ends_with($field, '_id')) {
+            $fieldValue = $model->$field ?? '';


The variable $fieldValue is assigned but never used. Consider removing it or using it in the Form::dbSelect call instead of the separate call on line 165.

Copilot · 2025-08-20T15:58:36Z

koot/libs/model_lite_form.php

+        // If the field ends with '_id', use a database select
+        if (str_ends_with($field, '_id')) {
+            $fieldValue = $model->$field ?? '';
+            $html .= Form::dbSelect("{$modelName}.{$field}", null, null, 'Select', '', $fieldValue) . PHP_EOL;


The variable $fieldValue is used but it was defined in the previous line. However, it should use $model->$field ?? '' directly or ensure the variable is properly utilized.

Suggested change

$html .= Form::dbSelect("{$modelName}.{$field}", null, null, 'Select', '', $fieldValue) . PHP_EOL;

$html .= Form::dbSelect("{$modelName}.{$field}", null, null, 'Select', '', $model->$field ?? '') . PHP_EOL;

henrystivens and others added 30 commits October 5, 2024 12:37

Rename MySQL schema from ku_admin to koot

aebe25a

The MySQL schema previously named `ku_admin` has been renamed to `koot`. This includes modifications to the schema and table names, adjusting primary key, unique index, and foreign key constraints to reflect the new schema name.

Updates admin navigation links

0fbe38e

Updates the admin navigation links to include trailing slashes. This ensures consistent routing and proper resource loading. The "Roles" link has been removed.

Adds accessibility labels to navigations

dee8d70

Improves accessibility by adding aria-label attributes to the navigation elements.

Removes unused create views

6952b84

Removes the unused create views for resources and users. These views are no longer needed and are being removed to clean up the codebase.

Merge pull request #3 from henrystivens/create-scaffold

0b42255

Create scaffold

Removes role creation view

d641598

Removes the dedicated view for creating roles within the admin panel. This change may be part of a broader refactoring or simplification of role management functionality.

Fixes admin URL navigation issue

9e3dd99

Ensures correct navigation to the admin users page by adding a trailing slash to the URL in the navigation links. This resolves an issue where the admin users page was not being loaded correctly.

Validates user email uniqueness

62065e6

Ensures email uniqueness during user creation and updates to prevent duplicate accounts. Adds checks in `_beforeCreate` and `_beforeUpdate` methods to validate email existence against the database.

Enables session management

2072470

Adds session management to the admin controller. This ensures user sessions are properly handled within the administrative interface.

Configures SQLite as default database

50c7bc0

Sets SQLite as the default database configuration. This change simplifies initial setup and is more suitable for development environments.

Renames default SQLite database file

2ff8397

Updates the default SQLite database file name from `ku_admin.db` to `koot.db` for clarity and consistency.

Clean theme switcher js

b08bc4c

Small change to maintain getter values

d7fdd4e

Move theme switcher js to dir js

c0d43a9

Better code in set scheme

fb1262e

Fix logo in css till changed

ac08212

Fix logo with css till changed

99e688a

Add _koot.css and min using rollup

1bafb43

Fix type hint in controllers

b17400f

Admin template use js dir

132d82c

Change scaffold lite views

2785b55

Add class logo to the svg

209342e

Fixes admin URL navigation issue

b02aa72

Ensures correct navigation to the admin users page by adding a trailing slash to the URL in the navigation links. This resolves an issue where the admin users page was not being loaded correctly.

Declares model property as a string

52d30b3

Ensures type safety by explicitly declaring the model property as a string.

Updates Koot CSS for 2025

11b9f22

Updates the Koot CSS file to reflect the 2025 version.

Refactors display of data in table format

987a2a8

Improves the data display in tables by ensuring that the "No records" message is displayed correctly when no data is available. Also, ensures the return statement does not interfere with the rendering of the rest of the page.

Fixes conditional rendering issue in show view

845ec8a

Corrects an issue where the conditional `endif` statement was not properly placed, potentially causing rendering errors. This change ensures the conditional logic functions as intended.

Styles "Record not found" actions

989c262

Enhances the appearance of the "Record not found" page actions by applying Bootstrap button styles, improving usability and visual appeal.

Merge branch 'dev' into create-scaffold

da720ab

henrystivens added 7 commits February 15, 2025 18:37

Fixes conditional check for empty data

a34bc36

Corrects the conditional statement to properly check if the `$data` variable is not set or if it contains no records.

Updates record not found message

9d9413e

Ensures the "Record not found" message is properly translated by using the correct PHP syntax for outputting the translated string.

Corrects model name casing in ResourcesController and RolesController

40a6f15

Adds error message for failed user creation in ControllerScaffoldLite

c76505e

Refactors ModelLiteForm class for improved readability and structure

f90a664

Fixes output rendering for ModelLiteForm in create view

cb227c2

henrystivens requested a review from joanhey April 18, 2025 23:54

henrystivens requested a review from Copilot August 20, 2025 15:57

henrystivens self-assigned this Aug 20, 2025

Copilot AI reviewed Aug 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create scaffold for LiteRecord#58

Create scaffold for LiteRecord#58
henrystivens wants to merge 37 commits intoKumbiaPHP:masterfrom
henrystivens:create-scaffold

henrystivens commented Apr 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<h1><?= ucwords("$model"), ": <span>$action_name</span>" ?></h1>
	<h1><?= ucwords("$model") . ": <span>$action_name</span>" ?></h1>

-            return;
+            if ($obj->create(Input::post($this->model))) {
+                // Success message and return to the list
+                Flash::valid(_('Record created'));
+                Redirect::toAction('');
+                return;
+            } else {
+                Flash::error(_('Something was wrong'));
+                // If it fails the data is persistent in the form
+                $this->{$this->model} = $obj;
+                return;
+            }

	$html .= Form::dbSelect("{$modelName}.{$field}", null, null, 'Select', '', $fieldValue) . PHP_EOL;
	$html .= Form::dbSelect("{$modelName}.{$field}", null, null, 'Select', '', $model->$field ?? '') . PHP_EOL;

Uh oh!

Conversation

henrystivens commented Apr 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants