Skip to content

fix for tooltips by @Orionshock #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KarrokDC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix for tooltips by @Orionshock #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204353e
fix for tooltips by @Orionshock
KarrokDC Jan 20, 2023
a270ef8
semicolons
KarrokDC Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions services/tooltip-service.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ function TooltipService:CheckTooltip(tooltip)
-- check if skill not found yet
if (not skill) then
-- check if small text is reagents
local text1 = GameTooltipTextLeft1:GetText();
local text2 = GameTooltipTextLeft2:GetText();
local text3 = GameTooltipTextLeft3:GetText();
local text1 = _G[ tooltip:GetName().."TextLeft1" ]:GetName();
local text2 = _G[ tooltip:GetName().."TextLeft2" ]:GetName();
local text3 = _G[ tooltip:GetName().."TextLeft3" ]:GetName();
if (text1 and (text2 and string.find(text2, SPELL_REAGENTS) == 1 or text3 and string.find(text3, SPELL_REAGENTS) == 1)) then
-- find skill by name
skillId, skill, professionId = addon:GetService("professions"):FindSkillByName(text1);
Expand Down