Merged
Conversation
I find their implementation of Expects and Ensures terrible, because they just std::terminate the app without providing information, how, why and where the app crashed. I replaced them with BeeExpects and BeeEnsures long ago. gsl::not_null is good, but i don't want to use gsl library only for not_null
- Made BeeEngine as another nix package and added find_library to Editor - Moved imguizmo back to engine (temporary...hopefully) - Added option to disable building of BeeEngine library - moved all compile definitions from Engine to another file - Some includes from BeeEngine in Editor use now <> - Changed generation of include files from install time to configuration time (may be changed later) - Enabled profiling for both Release and Debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's impossible to use BeeEngine as an external library for another C++ Projects and I'm unable to decouple builds of Editor, Localization tool, tests and the Game Engine itself. This pull request should fix the first part: It should be possible to build beeengine nix package as a library with static library and include files, so it could be used in another projects with cmake with find_library.
In order to achieve this goal, a cleanup should be performed beforehand