Fix XmlPatch attribute selector matching on intermediate nodes#13
Merged
elementgreen merged 1 commit intoKymorphia:masterfrom Feb 16, 2026
Merged
Fix XmlPatch attribute selector matching on intermediate nodes#13elementgreen merged 1 commit intoKymorphia:masterfrom
elementgreen merged 1 commit intoKymorphia:masterfrom
Conversation
The selAttrId was incorrectly checked on all nodes in the selector path instead of only the final target node, causing rename attribute operations with multi-level selectors to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selAttrId was incorrectly checked on all nodes in the selector path instead of only the final target node, causing rename attribute operations with multi-level selectors to fail.
If we leave the unittest without these changes we get: