Most of the xml_patch unittests#14
Merged
elementgreen merged 4 commits intoKymorphia:masterfrom Feb 16, 2026
Merged
Conversation
source/xml_patch.d
Outdated
| patch.parseRenameCmd("root.node[][old_attr]"d, "new_attr"d); | ||
| patch.apply(tree, null); | ||
|
|
||
| assert(!("old_attr" in tree.root.children[0].attrs)); |
Contributor
There was a problem hiding this comment.
I usually use !in, but not that big of a deal.
source/xml_patch.d
Outdated
| auto patch = new XmlPatch(); | ||
| bool caught = false; | ||
|
|
||
| try |
Contributor
There was a problem hiding this comment.
Can we use assertThrown for this and others below? Example:
assertThrown!XmlPatchError(patch.parseSelector("node[=value]"d));For cases where try/catch are used, I prefer to leave out the braces when there is only one statement in the try or catch blocks, to try and keep such code more compact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aim is for near-full coverage.
There are 3-4 unittests that are failing and they need to be dealt separately (investigate why are they failing as they are support to pass).
Coverage of this module will be around 80% when we merge this.