update activity relink to only show relevant #1493
Conversation
databases and avoid unsafe activity opening in relink dialogue. Avoid error of undefined failed variable in relink Resolves LCA-ActivityBrowser#1167
|
Hi @tsgfan07 Thanks a lot for taking the time to contribute to AB! @mrvisscher is currently out-of-office until ~half July, he will have a look at this once he's back. Sorry for the delay, but we haven't forgotten this PR :) |
|
Hi @tsgfan07, Thank you so much for your PR, it is much appreciated! It seems to be working perfectly, I've made one remark that could improve the functioning of the action significantly. Would you take a look? Kind regards, Marin |
| depends = db.find_dependents() | ||
| # find the dependents for the activity using bw2data method and construct the alternatives in tuple format | ||
| data = {} | ||
| data[activity.key] = db.load()[activity.key] |
There was a problem hiding this comment.
I am slightly worried about this. db.load() is a very intensive function, and although I realize db.find_dependents() also uses this method, it will be very VERY slow for a database the size of ecoinvent.
The data we need is already there in activity.exchanges(). It should be a lot quicker to just iterate over them and make a set of their input databases.
4 participants
Resolves #1167
Show only relevant databases for activity relink
Uses bw2data function as previously, but provides keyword arguments to the db.dependents() function.
Also avoids error of non-existing failed variable for opening relink dialogue for activities without exchanges.Lastly, updated relink dialogue to use safe_open_activity_tab signal (unsafe open is broken)
Checklist
./activity_browser/docs/wikiIf you have write access (otherwise a maintainer will do this for you):
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog.