[WIP] Source/microphone directivity for ray tracing#180
Open
[WIP] Source/microphone directivity for ray tracing#180
Conversation
…id shaped distribution
…idSphere if necessary
ebezzam
reviewed
Jul 27, 2020
…ampling in the Directivity class.
…to avoid circular dependency.
…d-tree (via nanoflann)
* Adds implementation of Antoni's octave band filters. * Replaces the old cosine octave filter bank by the energy preserving perfect reconstruction filter bank from Antoni 2009.
…rce model for source directivities. This enables the use of source directivities with non-shoebox rooms.
… sampling rays. Adds tests for these distributions as well as for the random sub-package.
…ls and frequency bands.
…s to use the package wide rng by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have started work for the source directivity of the ray tracer. The idea is to implement the drectivity as a random sampling of the rays on the sphere from the distribution induced by the source directivity. This requires to sync a number of features with the source directivity for the ISM, in particular, the energy should be matched, which requires to know the integral of the source directivity patterns. Ideally, we should store all of this in easy use classes.
[ ] Energy matching with ISM (can be done by using rejection sampler efficiency to estimate volume)
[ ] Volume/Area functions for cardioid
[X] Add interface to provide ray directions to the C++ engine.
[X] Power spherical distribution sampler is implemented
[ ] Power spherical distribution pdf
[X] Rejection sampler
[X] Sampler for Cardioid and family distributions on the sphere (using rejection sampling)
[X] The
SphericalHistogramclass provides a way of testing distributions on the sphere via statistical tests.[X] directional histograms in libroom.Microphone using a kd-tree
[ ] Tests: via statistical tests ?
[ ] docstrings
[ ] Doc building ?
[ ] Add to CHANGELOG