Skip to content

Erik/harmonicscomments#427

Open
je-fleischhauer wants to merge 2 commits intoLCAV:masterfrom
je-fleischhauer:erik/harmonicscomments
Open

Erik/harmonicscomments#427
je-fleischhauer wants to merge 2 commits intoLCAV:masterfrom
je-fleischhauer:erik/harmonicscomments

Conversation

@je-fleischhauer
Copy link
Contributor

This merge request builds upon #422 .

  • My previous comments were a bit sloppy. I have revised the comments on the module. (But there is still room for improvement!)
  • I adapted the unit test to increase the code coverage.
  • I corrected a slip between order and degree of spherical harmonics.
  • I added some checks to make the code more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant