Feature/periodogram improvements #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capetillo
reviewed
Dec 4, 2025
| } | ||
| // Image dragged into the selected images area | ||
| function insert(inputKey, index, event) { |
Collaborator
There was a problem hiding this comment.
just a suggestion, would it make sense to make this function into a utils function since other operations use insert logic?
Collaborator
There was a problem hiding this comment.
I'm realizing that this component is global. Ignore!
capetillo
approved these changes
Dec 8, 2025
Collaborator
capetillo
left a comment
capetillo
left a comment
There was a problem hiding this comment.
LGTM! P.S. Have we figured out why the dragging scale lost its blue color?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of changes in here so it might be easiest to just talk it over, but I'll try to at least put an outline here:
OperationWizard- including new 'source' type with its ownSourceInputWidgetwhich can do a source lookup by name and provides a name/ra/dec to the operationMultiImageInputSelectorused by the wizard to allow restricting by filter, and allow selecting all images of a given filter from a dropdown - keyed on new keywords in the operations wizard descriptionImageGridinto a more genericOperationOutputGridthat can support both images and non-image data output in a grid view. TheImageGridstill exists since it is used for input image selection, which is kind of different now from showing outputDataOutputwhich encapsulates generic data output (as opposed to image output) from operations. It has code to show a sparkline plot of light curve or period data as well as the source / operation nameAnalysisViewintoImageAnalysisViewand only launch it from image data.DataAnalysisViewwhich is launched fromDataOutputdata. This is where your code for showing the light curve, periodogram, and phased light curve will go. The more generic and piecemeal this is the better, since we will likely have to extend this to show other data output stuff later with new operations.