Skip to content

Simplifying obs tab, no lazy loading #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrfarah wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Simplifying obs tab, no lazy loading #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ded7369
removed obs tab from the mutation observer monitoring
jrfarah Feb 11, 2026
8fa25a1
removed lazy loading
jrfarah Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions templates/tom_targets/target_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<a class="nav-link tab-loading" id="detail-tab" href="#detail" role="tab" data-toggle="tab" data-tab-name="details">Details</a>
</li>
<li class="nav-item">
<a class="nav-link tab-loading" id="observations-tab" href="#observations" role="tab" data-toggle="tab" data-tab-name="observations">Observations</a>
<a class="nav-link" id="observations-tab" href="#observations" role="tab" data-toggle="tab" data-tab-name="observations">Observations</a>
</li>
<li class="nav-item">
<a class="nav-link tab-loading" id="manage-data-tab" href="#manage-data" role="tab" data-toggle="tab" data-tab-name="manage-data">Manage Data</a>
Expand Down Expand Up @@ -184,7 +184,30 @@ <h4>Spectroscopy</h4>
<div style="text-align: center; padding: 50px;">Loading details...</div>
</div>
<div class="tab-pane" id="observations">
<div style="text-align: center; padding: 50px;">Loading observations...</div>
<h4>Schedule Observations</h4>
{% observing_buttons object %}
<hr/>
<button onclick="display_obs()" class="btn" style="background-color: white; color: black; font-size: 16px; border: none; outline: none; box-shadow: none;">Show Previous Observations</button>
<div class="row" id="previous-obs" style="display: none; color: gray;">
{% observation_summary object 'previous' %}
</div>
<div class="row" id="ongoing-obs" style="display: block">
{% observation_summary object 'ongoing' %}
</div>
<div class="row" id="pending-obs" style="display: block; color: orange;">
{% observation_summary object 'pending' %}
</div>
{% submit_lco_observations object %}
<script>
function display_obs() {
var x = document.getElementById("previous-obs");
if (x.style.display === "none") {
x.style.display = "block";
} else {
x.style.display = "none";
}
}
</script>
</div>
<div class="tab-pane" id="manage-data">
<div style="text-align: center; padding: 50px;">Loading manage data...</div>
Expand Down Expand Up @@ -273,7 +296,7 @@ <h4>Spectroscopy</h4>
// Load all tabs in background after a short delay
setTimeout(function() {
var targetId = {{ target.id }};
var tabsToLoad = ['details', 'observations', 'manage-data', 'observing-runs', 'images', 'photometry', 'spectroscopy'];
var tabsToLoad = ['details', 'manage-data', 'observing-runs', 'images', 'photometry', 'spectroscopy'];

tabsToLoad.forEach(function(tabName, index) {
// Stagger the loading to avoid overwhelming the server
Expand Down Expand Up @@ -660,6 +683,12 @@ <h4>Spectroscopy</h4>
return;
}

// Skip monitoring for iframes inside the observations tab
if ($iframe.closest('#observations').length > 0) {
console.log('Skipping Dash monitoring for observations tab iframe');
return;
}

// Generate a unique ID for this iframe
var iframeId = $iframe.attr('id') || ('dash-iframe-' + Math.random().toString(36).substr(2, 9));
if (!$iframe.attr('id')) {
Expand Down