-
Notifications
You must be signed in to change notification settings - Fork 10
GH-433: [License] Adding Apache 2.0 License and Copyrights to each file on the repo #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @vibhatha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on adding and managing Apache 2.0 license headers across the OpenGIN repository. It introduces two new Python scripts to automate the process of adding license headers and managing them for different components. The PR also updates the .gitignore file to exclude the scripts' cache directory. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Apache 2.0 license headers to numerous files across the repository and introduces two Python scripts, add_license_headers.py and manage_licenses.py, to automate this process. My review focuses on these new scripts. I've suggested improvements to make them more robust and user-friendly, such as enhancing the license detection logic, fixing a minor output typo, and making the script for managing licenses less dependent on the directory it's run from.
…les, and update the license script to include proto files.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ng license headers.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the Apache 2.0 license and copyright headers to numerous files across the repository, which is a great step for project clarity and compliance. It also introduces two new Python scripts, add_license_headers.py and manage_licenses.py, to automate this process. My review focuses on these new scripts, and I've provided some suggestions to improve their robustness and adherence to best practices, such as refining exception handling, improving the license detection logic, and making path resolution more reliable.
…icense management in `DEVELOPMENT.md`.
This PR includes a script to include the License and Copyrights for the source files.
This PR closes #433