Skip to content

Conversation

@zaeema-n
Copy link
Collaborator

This pr closes #440.

Postgres table names are now generated using uuid such that they never exceed postgres' table name character limit.

@zaeema-n zaeema-n requested a review from vibhatha January 23, 2026 08:06
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zaeema-n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant change to how PostgreSQL table names are generated and managed within the system. By adopting UUIDs for table names, it resolves potential issues with identifier length limits in PostgreSQL, ensuring greater stability and scalability. The update also refines the logic for retrieving these dynamically generated table names and extends UUID-based identification to internal attribute and relationship IDs, streamlining the overall data management architecture.

Highlights

  • PostgreSQL Table Naming Convention: PostgreSQL table names are now generated using UUIDs (Universally Unique Identifiers) to prevent exceeding the character limit, addressing issue Postgres table name can exceed character limit #440. This ensures robust and unique table identification.
  • Dynamic Table Name Retrieval: The system now dynamically retrieves table names from the entity_attributes table using entityID and attributeName, rather than constructing them from these identifiers. This change accommodates the new UUID-based naming scheme.
  • UUID-based Attribute and Relationship IDs: Internal attribute and relationship IDs are also updated to be UUID-based, enhancing their uniqueness and consistency across the system.
  • Dependency Update: The github.com/google/uuid package has been added to manage UUID generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the issue of Postgres table names exceeding the character limit by switching to UUID-based names. The changes are well-implemented across the write path, read path, and tests. The logic for generating a UUID-based table name and then looking it up for read operations is correct and robust.

My feedback focuses on improving code quality by addressing some minor code duplication and adhering to Go's idiomatic naming conventions. These changes will enhance the maintainability and readability of the code.

Copy link
Member

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding minor comments. Overall LGTM!

@zaeema-n zaeema-n merged commit 8da76ef into LDFLK:main Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Postgres table name can exceed character limit

2 participants