PF hit association #1856
Open
PF hit association #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomeichlersmith
requested changes
Oct 2, 2025
Member
tomeichlersmith
left a comment
tomeichlersmith
left a comment
There was a problem hiding this comment.
This is looking good, I have a few cleanup requests and one comment about sharing EcalGeo information with CLUE.
Remove remnant of attempt to set hits directly Co-authored-by: Tom Eichlersmith <31970302+tomeichlersmith@users.noreply.github.com>
Co-authored-by: Tom Eichlersmith <31970302+tomeichlersmith@users.noreply.github.com>
Contributor
Author
|
The failing histogram tests are caused by a name change |
tomeichlersmith
approved these changes
Oct 6, 2025
tvami
reviewed
Oct 9, 2025
tvami
reviewed
Nov 27, 2025
Comment on lines
+121
to
+122
| cluster.nbrOfLayers = 1 | ||
| cluster.nbr_of_layers = cluster.nbrOfLayers #just here to highlight confusion |
Member
There was a problem hiding this comment.
We dont anymore have nbrOfLayers parameter
https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Ecal/python/ecalClusters.py#L37
Suggested change
| cluster.nbrOfLayers = 1 | |
| cluster.nbr_of_layers = cluster.nbrOfLayers #just here to highlight confusion | |
| cluster.nbr_of_layers = 1 |
tvami
reviewed
Nov 27, 2025
Comment on lines
+12
to
+14
| // ldmx-sw objects | ||
| // #include "Ecal/Event/EcalHit.h" | ||
| // #include "Hcal/Event/HcalHit.h" |
Member
There was a problem hiding this comment.
Suggested change
| // ldmx-sw objects | |
| // #include "Ecal/Event/EcalHit.h" | |
| // #include "Hcal/Event/HcalHit.h" |
Member
we need to have this with a default in the python file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This allows association back to hits from clusters that were associated with PF tracks in the PFlow algorithm. It also includes a first go at a pileup electron identifier processor, that subtracts hits associated to high-momentum tracks from the ecal rechit collection (or rather, makes a new collection without those hits).
Check List
Plot showing 10 2e inclusive events, ecal rec hits x: black is all hits, red is after pileup removal. This is not at all optimized yet (clustering needs improvements) but the principle works.