-
Notifications
You must be signed in to change notification settings - Fork 2
Make ECON readout batched #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0275aed to
6df85f0
Compare
|
I think this is great, I just want to test it with a real ECON - unfortunately, the tests run by |
Yeah I'd love to do this today, let me know when we can do it together! |
|
@cmantill It looks okay to me, but I would like you to weigh in. This batching appears to make things faster when attempting to (for example) |
|
We ran the econd_0_settings_20251121_093052.yaml - on branch with no difference in There are differences between these two |
|
Looks good but I'd like to test it first |
|
I think this is breaking things - did you change anything in the ECON configuration between taking these DUMPs? |
|
I did not change anything but the ECON and ROCs were in RUNMODE |
|
Ok, as I said to @tvami - speeding up the application/reading of parameters is lower priority so if there is a hint of breaking things, then I am not going to merge this. I'm going to drop this back to draft and we can test it after things cool down. |
|
Yes, some read only parameters will change but your dump shows read/write parameters changing, so something is off. |
|
@cmantill thanks for checking this! Can you point me to which of the parameters you are looking at to check this? |
|
For example: Actually, one thing that would be super useful to have is a standalone "TASK" that can test this. Could you write it? In it, attempt to read the following parameters:
And print the addresses that is trying to read as well as the full output from "getValues". The last two registers should be contiguous but not the first one. I am wondering if there is something that is being broken by a continuous read that does not respect the boundary of registers. |
Maybe this resolves #266 ?
Now the ECON class also does things in batches, I dont know if this makes sense, but like this it's more like how the ROC does it and certainly will be faster.
The following works:
But we should test it in the real case too, so I'm opening this as a draft for now