-
Notifications
You must be signed in to change notification settings - Fork 9
Migrate JWT to SIWE for App registration in e2e test utils #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
41c75c3
fix: convert jwt auth to siwe
Spacesai1or 4d7da1f
chore: bump e2e-test-utils to alpha version
Spacesai1or b08cc44
chore: linter
Spacesai1or 0626329
chore: pnpm i
Spacesai1or 79a0ec9
Merge branch 'main' into fix/jwt-to-swi-api-auth
Spacesai1or 725370c
chore: linter
Spacesai1or b5f48ef
chore: pnpm i
Spacesai1or f7da4e2
chore: linter fixes
Spacesai1or 03e38d7
chore: linter
Spacesai1or b230ec6
chore: build errors
Spacesai1or File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,4 +58,4 @@ export async function getAgentFunds( | |
| tokens: data.data.tokens, | ||
| pageKey: data.data.pageKey, | ||
| }; | ||
| } | ||
| } | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,3 @@ | ||
| export { | ||
| deploySmartAccount, | ||
| ensureWalletHasTokens, | ||
| getEnv, | ||
| setupVincentDevelopmentEnvironment, | ||
| } from './setup-dev-env'; | ||
| export { ensureWalletHasTokens, getEnv, setupVincentDevelopmentEnvironment } from './setup-dev-env'; | ||
|
|
||
| export type { SetupConfig, SmartAccountInfo, VincentDevEnvironment } from './setup-dev-env'; | ||
| export type { SetupConfig, VincentDevEnvironment } from './setup-dev-env'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| export { setupVincentDevelopmentEnvironment } from './setupVincentDevEnv'; | ||
| export { getEnv } from './getEnv'; | ||
| export { deploySmartAccount } from './smart-account/deploySmartAccount'; | ||
| export { ensureWalletHasTokens } from './wallets/ensureWalletHasTokens'; | ||
|
|
||
| export type { SetupConfig, VincentDevEnvironment } from './setupVincentDevEnv'; | ||
| export type { SmartAccountInfo } from './smart-account/deploySmartAccount'; |
77 changes: 0 additions & 77 deletions
77
packages/libs/e2e-test-utils/src/setup-dev-env/smart-account/createPermissionApproval.ts
This file was deleted.
Oops, something went wrong.
169 changes: 0 additions & 169 deletions
169
packages/libs/e2e-test-utils/src/setup-dev-env/smart-account/deploySmartAccount.ts
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
packages/libs/e2e-test-utils/src/setup-dev-env/smart-account/deriveSmartAccountAddress.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 0 additions & 34 deletions
34
packages/libs/e2e-test-utils/src/setup-dev-env/vincent-registry-api/generateAppManagerJwt.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package still imports
@lit-protocol/contracts-sdk(specificallyLitContractsinsrc/setup-dev-env/wallets/ensureWalletHasCapacityCredit.ts), but it's being removed from direct dependencies. While this dependency is transitively available through@lit-protocol/vincent-contracts-sdk, relying on transitive dependencies is fragile and can break if the parent package removes it. Consider either keeping@lit-protocol/contracts-sdkas a direct dependency or refactoringensureWalletHasCapacityCreditto not use it.