feature: add new reduction valop / valloc interface to kernel #1799
Conversation
|
@LLNL/raja-core It would be nice to get a preliminary review on this PR. I'm still working on the openmp implementation of this feature, but HIP and CUDA are passing the basic unit tests demonstrated in the PR |
|
@johnbowen42 , I took a look -- Overall its looking pretty good! My one comment is that we should add 2 lambda test just to verify that works as well. |
… into feature/bowen/add-valop-kernel
|
@johnbowen42 would also be able to add the kernel naming capability? It should be copy paste from one of the forall or launch implementations |
I think I want to handle this in a follow up because of the already large size of this PR. #1827 to track |
Added a multiple lambda unit test |
| namespace internal | ||
| { | ||
|
|
||
| struct ParamBase | ||
| {}; | ||
|
|
||
| } // end namespace internal |
There was a problem hiding this comment.
An alternative would be to make an alias here instead of changing it everywhere.
|
This PR is now dependent on LLNL/camp#174 for merging. CI will be broken until this is merged |
This PR enables the
RAJA::expt::Reduceinterface to work inside RAJA::kernels. See examples/kernel-reduction.cpp for an example