Adds an override for the location of the .benchpark directory #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+20
to
+23
| try: | ||
| benchpark_home = pathlib.Path(os.environ["BENCHPARK_HOME"]) | ||
| except KeyError: | ||
| benchpark_home = pathlib.Path(os.path.expanduser("~/.benchpark")) |
There was a problem hiding this comment.
Could we not do
Suggested change
| try: | |
| benchpark_home = pathlib.Path(os.environ["BENCHPARK_HOME"]) | |
| except KeyError: | |
| benchpark_home = pathlib.Path(os.path.expanduser("~/.benchpark")) | |
| # If location is not set, use user home as default location | |
| benchpark_home = pathlib.Path(os.getenv("BENCHPARK_HOME", os.path.expanduser("~/.benchpark"))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds a simple override for the location of the
.benchparkdirectory via aBENCHPARK_HOMEenvironment variable.This is a bit of a niche feature, but it can be useful e.g., when trying to install Benchpark in a container.
Adding/modifying core functionality, CI, or documentation: