Fixes a bug with fire aspect and entity killing quests #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I don't see possibility that it fixes the issue. Have you even tested it? On which server software and version? |
Author
|
I tested this on a 1.21 Spigot server and it did fix the issue. With the plugin as downloaded from GitHub any mobs which died to due to fire from a Fire Aspect sword did not count for the quest, however with this fix they did. LivingEntity.getKiller() gets the player which Minecraft assigns to be the killer of a mob, which in the case of a mob dying by fire is either null or the player who hit it within the last five seconds (See https://minecraft.wiki/w/Experience#Sources). |
Still fallback to last damage event damager if null. It doesn't really fix LMBishop#752, however possibly allows for Fire Aspect tracking of entities ignited within last 5 seconds (similarly to different built-in game mechanics).
Collaborator
|
Maybe it's actually okay for mobkilling, however I want it to still fallback to the last damage cause damager - changed it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752 by switching the method of finding the entity killer from last damage source to entity.getKiller().