Apply patches for Perl 5.42 #109
Conversation
CPAN/Scan.xs.patch
Outdated
There was a problem hiding this comment.
Isn't this a change which should go upstream to the module's repository (https://github.com/LMS-Community/Audio-Scan)?
There was a problem hiding this comment.
Yes, I can move it upstream. Hopefully the change is backwards compatible, otherwise patching might be the easier solution.
There was a problem hiding this comment.
I've removed the patch in anticipation that the upstream PR will be accepted prior to this.
There was a problem hiding this comment.
Well, we can live in hope ;-)
There was a problem hiding this comment.
Version 1.11 of Audio-Scan has now been released. I've updated the buildme.sh file and added the new archive to the CPAN directory, using the download from this link, the sha256sum of which is:
1bed2a6aa3f6735c3f50ab8e9916b0abfa8a663b16bd95334c09790ba1fa6d42
There was a problem hiding this comment.
Is this file specific to the EV build?
There was a problem hiding this comment.
There was a problem hiding this comment.
Could you please rename the patch to something like EV-typemap.patch?
| cd EV-4.03 | ||
|
|
||
| if [[ "$PERL_VERSION" -ge "5.42" ]]; then | ||
| patch typemap ../EV-typemap.patch || true |
There was a problem hiding this comment.
Note that I can skip the || true bit if desired. This was done to allow repeat builds for the AUR package, i.e. if you made some edits and re-ran the build. It also means that the build won't exit if EV is patched/fixed upstream.
michaelherger
left a comment
michaelherger
left a comment
There was a problem hiding this comment.
Let's give that a try - thanks!
|
It looks like my version check for the EV patch isn't working. I'll debug locally and push a fix. |
2 participants
This PR closes #108 by applying patches to the
AudioScanandEVmodules so that they work with Perl 5.42 (and presumably above). The same patches have successfully been applied to the Arch Linuxlyrionmusicserverpackage from the AUR, available here. (The PR with the fixes is here.) I thought I'd move the fix upstream so that it was (hopefully) useful to a wider audience.