Open
Conversation
DamienVesper
requested changes
Nov 17, 2025
| [HttpGet] | ||
| public async Task<IActionResult> GetAllPurchaseAsync([FromQuery] PurchaseRequestSearchDto? dto) | ||
| { | ||
| var result = await _purchaseRequestService.GetAllPurchaseRequestsAsync(dto ?? new PurchaseRequestSearchDto()); |
Member
There was a problem hiding this comment.
Why are we making a new DTO here? There should only exist 1 instance of a DTO as it's a singleton.
| return Ok(result); | ||
| } | ||
|
|
||
| [HttpGet("{id:guid}", Name = "GetPurchaseRequestById")] |
Member
There was a problem hiding this comment.
Need to be able to search by informal ID (i.e. TR26-001), author, and subsystem.
Member
There was a problem hiding this comment.
Opt to use the .env instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fully implemented and tested the purchase request service